Skip to content

Fix Integration Test Log Dumping For Storage Backends #5915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 1, 2024
Merged

Fix Integration Test Log Dumping For Storage Backends #5915

merged 8 commits into from
Sep 1, 2024

Conversation

@mahadzaryab1
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 commented Sep 1, 2024 •
edited
Loading

Which problem is this PR solving?

Resolves #5912

Description of the changes

  • Removed the log dumps in the CI workflow files and replace them with log dumps in the script files

How was this change tested?

  • I ran the scripts locally and deliberately made them fail to ensure that the logs get printed. I also checked that the logs don't get printed when the scripts pass.

Checklist

@codecov
Copy link

codecov bot commented Sep 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.82%. Comparing base (edc3152) to head (6cd6e20).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5915      +/-   ##
==========================================
+ Coverage   96.81%   96.82%   +0.01%     
==========================================
  Files         342      342              
  Lines       16525    16525              
==========================================
+ Hits        15998    16000       +2     
+ Misses        340      339       -1     
+ Partials      187      186       -1
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-3.x-v1 16.62% <ø> (ø)
cassandra-3.x-v2 1.75% <ø> (ø)
cassandra-4.x-v1 16.62% <ø> (ø)
cassandra-4.x-v2 1.75% <ø> (ø)
elasticsearch-6.x-v1 18.78% <ø> (ø)
elasticsearch-7.x-v1 18.85% <ø> (ø)
elasticsearch-8.x-v1 19.04% <ø> (ø)
elasticsearch-8.x-v2 1.81% <ø> (ø)
grpc_v1 9.49% <ø> (+0.01%) ⬆️
grpc_v2 7.16% <ø> (ø)
kafka-v1 9.74% <ø> (ø)
kafka-v2 1.82% <ø> (ø)
memory_v2 1.81% <ø> (-0.02%) ⬇️
opensearch-1.x-v1 18.89% <ø> (-0.02%) ⬇️
opensearch-2.x-v1 18.89% <ø> (-0.02%) ⬇️
opensearch-2.x-v2 1.81% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.30% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahadzaryab1 mahadzaryab1 changed the title [WIP] Fix Integration Test Log Dumping For Storage Backends Fix Integration Test Log Dumping For Storage Backends Sep 1, 2024
@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review September 1, 2024 01:49
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner September 1, 2024 01:49
@mahadzaryab1 mahadzaryab1 requested a review from jkowall September 1, 2024 01:49
@dosubot dosubot bot added the area/storage label Sep 1, 2024
@mahadzaryab1 mahadzaryab1 mentioned this pull request Sep 1, 2024
Closed
yurishkuro
yurishkuro approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Sep 1, 2024
@yurishkuro yurishkuro merged commit 8879938 into jaegertracing:main Sep 1, 2024
@mahadzaryab1 mahadzaryab1 deleted the dump-logs branch September 1, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees

No one assigned

Labels

area/storage changelog:ci Change related to continuous integration / testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reliably dump logs from integration tests

2 participants

@mahadzaryab1 @yurishkuro